feat(react-data-query): upgrade tanstack query to v5 - #9563
Conversation
Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
3f8e45a to
dc3ab8b
Compare
|
@n3ps Looks generally good. Can we see PRs that integrate a preview build of |
@mcmire |
|
@n3ps Ah thanks. To be clear, can you generate preview builds on this PR, upgrade your PRs for both clients to use the preview build for |
|
@metamaskbot publish-previews |
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
|
@mcmire Done — preview builds are published from this PR, and both client upgrade PRs now consume
Smoke-tested with unit tests on both clients after the install remap. |
mcmire
left a comment
There was a problem hiding this comment.
A couple of comments below.
a1f362b to
7d90020
Compare
Upgrade @tanstack/query-core and @tanstack/react-query to v5 and update createUIQueryClient's invalidateQueries override to the v5 filters/options signature (parseFilterArgs was removed). This is a breaking change for consumers still on TanStack Query v4. Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
7d90020 to
25bb0b9
Compare
A recent PR updated this package to v5 in one package (#9563). This PR updates to v5 in all remaining packages.
A recent PR updated this package to v5 in one package (#9563). This PR updates to v5 in all remaining packages.
A recent PR updated this package to v5 in one package (#9563). This PR updates to v5 in all remaining packages.
Upgrade @tanstack/query-core to v5 and update createUIQueryClient's invalidateQueries override to the v5 filters/options signature (parseFilterArgs was removed).
This unblocks clients from upgrading TanStack Query to v5
(Previously Extension was held back due to React v17, no longer applicable)
Explanation
References
Checklist
Note
High Risk
Major dependency upgrade with documented breaking changes to query client invalidation and infinite-query configuration; all consumers must migrate TanStack APIs in lockstep.
Overview
BREAKING: Bumps
@tanstack/query-coreand@tanstack/react-queryfrom v4 to ^5.62.16 so downstream apps can adopt TanStack Query v5.createUIQueryClientis updated for v5: the custominvalidateQuerieswrapper now takes(filters?, options?)only (v4’sparseFilterArgsoverloads are removed), andpageParamis passed to the messenger with an explicitJsoncast. TheuseInfiniteQuerywrapper’s generics align with v5 (InfiniteDatadefault,TPageParam, updatedUseInfiniteQueryOptionsarity).Tests and changelog call out consumer migrations:
gcTimeinstead ofcacheTime, andinitialPageParam(plus pagination callbacks) for infinite queries.Reviewed by Cursor Bugbot for commit 25bb0b9. Bugbot is set up for automated code reviews on this repo. Configure here.